[webkit-reviews] review denied: [Bug 67528] Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type. : [Attachment 107822] [patch] initial version

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 02:52:50 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 67528: Web Inspector: didMarkDOMContentEvent() should send event of
MarkDOMContent type.
https://bugs.webkit.org/show_bug.cgi?id=67528

Attachment 107822: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=107822&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107822&action=review


> LayoutTests/inspector/timeline/timeline-animation-frame.html:28
> +    function finish()

Is this a part of this patch?

> LayoutTests/inspector/timeline/timeline-dom-content-loaded-event.html:11
> +    InspectorTest.startTimeline(function() { InspectorTest.reloadPage(); });


Tests should not reload the page, please use iframe instead.


More information about the webkit-reviews mailing list