[webkit-reviews] review granted: [Bug 68144] Web Inspector: skip overlapping scripts when displaying concatenated content. : [Attachment 107471] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 19 00:37:28 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 68144: Web Inspector: skip overlapping scripts when displaying concatenated
content.
https://bugs.webkit.org/show_bug.cgi?id=68144

Attachment 107471: Patch
https://bugs.webkit.org/attachment.cgi?id=107471&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107471&action=review


> Source/WebCore/inspector/front-end/SourceFile.js:274
> +	      if (lineNumber > scripts[i].lineOffset || (lineNumber ===
scripts[i].lineOffset && columnNumber > scripts[i].columnOffset -
scriptOpenTag.length))

Could you also investigate when this happens? I.e. can we process scripts added
via appendChild differently?


More information about the webkit-reviews mailing list