[webkit-reviews] review denied: [Bug 67875] Remove toPrimitive from JSCell : [Attachment 107708] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied  review:
Bug 67875: Remove toPrimitive from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67875

Attachment 107708: Patch
https://bugs.webkit.org/attachment.cgi?id=107708&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107708&action=review


> Source/JavaScriptCore/runtime/JSCell.cpp:124
> +    if (isString())
> +	   return ((JSString*)this)->toPrimitive(exec, preferredType);
> +    return ((JSObject*)this)->toPrimitive(exec, preferredType);

Use C++ static_cast, please. It's more explicit, and provides a little more
type safety than a C-style cast.

Are the bot complaints a real issue?