[webkit-reviews] review granted: [Bug 68318] DFG JIT should inline Math.min, Math.max, and Math.sqrt : [Attachment 107780] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 68318: DFG JIT should inline Math.min, Math.max, and Math.sqrt
https://bugs.webkit.org/show_bug.cgi?id=68318

Attachment 107780: the patch
https://bugs.webkit.org/attachment.cgi?id=107780&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
This looks really great.  It's a shame that the intrinsics are in addition to
the "thunk generators".  The old thunks are really for intrinsics.  It would
probably be cleaner to remove the ThunkGenerators from the lookup table, and
just have an enum value.  When native function objects are constructed the
thunk creation could just switch on the intrinsic enum value to select a
generator, where one exists (and maybe over time these may be deprecated, as
hot cases are inlined in the DFG JIT).