[webkit-reviews] review requested: [Bug 61344] --webkit-visual-word does not work in multi-line : [Attachment 107738] patch w/ layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 16 15:47:13 PDT 2011


Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 61344: --webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Attachment 107738: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=107738&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
These functions are only used in moving cursor by word, more specifically, the
2 newly added functions only triggered when finding word break on next or
previous line.
Considering the speed of key press in  real use case, where user press ctrl
(alt) + arrow to move cursor by word,  and considering the functions are only
triggered when searching words across line boundary ("\n" in text field, not
wrapped lines), I do not think performance is a concern here. Traversing DOM
node is a much cleaner/safer solution.


More information about the webkit-reviews mailing list