[webkit-reviews] review granted: [Bug 68272] [chromium] Move quad drawing code from LayerChromium to LayerRendererChromium : [Attachment 107712] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 68272: [chromium] Move quad drawing code from LayerChromium to
LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=68272

Attachment 107712: Patch
https://bugs.webkit.org/attachment.cgi?id=107712&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107712&action=review


R=me but if you are going to make it a member function I think you should use
LRC::m_context instead of passing one in.

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:38
> +#include "cc/CCLayerTreeHost.h"

was this transitively pulled in earlier or something? I guess this is needed so
~LayerRendererChromium can see ~CCLayerTreeHost because of the RefPtr<>

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h:154
> +    void drawTexturedQuad(GraphicsContext3D*, const TransformationMatrix&
projectionMatrix, const TransformationMatrix& layerMatrix,

If this is gonna be a member function, why does it need a context to be passed
in? LRCs have contexts