[webkit-reviews] review granted: [Bug 68269] Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way : [Attachment 107707] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 68269: Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement
in an ABI preserving way
https://bugs.webkit.org/show_bug.cgi?id=68269

Attachment 107707: Patch
https://bugs.webkit.org/attachment.cgi?id=107707&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107707&action=review


r=me

> Source/WebKit2/UIProcess/WebUIClient.cpp:166
> +    if (!m_client.version) {

This is a particularly glaring case where our style rule that compares to 0
should use ! is bizarre and unreadable. Oh well.