[webkit-reviews] review granted: [Bug 63541] TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber classes : [Attachment 107705] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Peter Rybin
<peter.rybin at gmail.com>'s request for review:
Bug 63541: TextPosition refactoring: Merge ZeroBasedNumber and OneBasedNumber
classes
https://bugs.webkit.org/show_bug.cgi?id=63541

Attachment 107705: Patch
https://bugs.webkit.org/attachment.cgi?id=107705&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This change is great.  Maybe instead of BasedNumber we should use the name
OrdinalNumber?

http://en.wikipedia.org/wiki/Ordinal_number

That's a number used for ordering as opposed to a number use for counting,
which is a cardinal number.