[webkit-reviews] review granted: [Bug 68265] add non-CG Webkit-Mac builds to flakiness dashboard : [Attachment 107696] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 16 12:04:32 PDT 2011

Adam Barth <abarth at webkit.org> has granted epoger at google.com's request for
Bug 68265: add non-CG Webkit-Mac builds to flakiness dashboard

Attachment 107696: Patch

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107696&action=review

> Tools/ChangeLog:6
> +	   Reviewed by Adam Barth. 

Generally you should leave this line with the default text.  The tools will
fill it in properly based on whoever actually reviews the patch.

> Tools/ChangeLog:7
> +

It's also a good idea to fill out some of the ChangeLog entry with an
explanation of why you're making this change.  In this case, I'd say something
about how we're preparing to make these the default builders.

> Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js:36
> -// FIXME: move this over to using qunit
> +// FIXME(ojan): move this over to using qunit

WebKit doesn't use the (ojan) notation.  Just FIXME.

More information about the webkit-reviews mailing list