[webkit-reviews] review denied: [Bug 67469] [WinCairo] IconDatabase::defaultIcon always fails for non-CAN_THEME_URL_ICON builds. : [Attachment 107412] WinCairo wants CAN_THEME_URL_ICON
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 16 11:58:05 PDT 2011
Brent Fulgham <bfulgham at webkit.org> has denied review:
Bug 67469: [WinCairo] IconDatabase::defaultIcon always fails for
non-CAN_THEME_URL_ICON builds.
https://bugs.webkit.org/show_bug.cgi?id=67469
Attachment 107412: WinCairo wants CAN_THEME_URL_ICON
https://bugs.webkit.org/attachment.cgi?id=107412&action=review
------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
Overall, the change looks good. However, it is missing a ChangeLog entry that
explains the change, who made the change, and provides a link to the bugzilla
entry.
Please revise the patch to include the ChangeLog (see the
http://www.webkit.org/coding/contributing.html page for details).
More information about the webkit-reviews
mailing list