[webkit-reviews] review granted: [Bug 67418] [chromium] Fix CCLayerTreeHostTest : [Attachment 107664] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Iain Merrick
<husky at google.com>'s request for review:
Bug 67418: [chromium] Fix CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=67418

Attachment 107664: Patch
https://bugs.webkit.org/attachment.cgi?id=107664&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107664&action=review


Good start.  I have some nits, but I can fix those on landing.

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:220
> +    void doEndTest()

This function seems unreachable

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:263
> +	       printf("Test timed out");
> +	       FAIL() << "Test timed out";

Very weird to printf() and FAIL().  The latter should produce valid output, no?


> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:279
> +    Mutex m_tracesLock;
> +    Vector<std::string> m_traces;

We don't use std::string in WebKit code - we use WTF::String.  These seem
completely unused, however.