[webkit-reviews] review denied: [Bug 68255] Demo of transferrable Typed Arrays between Web Workers using postMessage : [Attachment 107679] corrected demo of web workers with transferrable typed arrays

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 16 11:27:05 PDT 2011


Kenneth Russell <kbr at google.com> has denied  review:
Bug 68255: Demo of transferrable Typed Arrays between Web Workers using
postMessage
https://bugs.webkit.org/show_bug.cgi?id=68255

Attachment 107679: corrected demo of web workers with transferrable typed
arrays
https://bugs.webkit.org/attachment.cgi?id=107679&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Thanks for doing this work. I'm looking forward to seeing what this looks like
running on top of the new Transferable support for typed arrays. However, there
are several problems with this patch. First, this demo doesn't belong in the
WebKit repository. You can submit a patch against the demos in the Khronos
repository at https://www.khronos.org/bugzilla/ . Second, the patch is missing
key new files like demo-multicore.js. Third, it replicates many files unused by
the vertex-buffer-object demo such as o3djs/particles.js. I'm marking this
patch r-. Please submit patches against this demo using the Khronos issue
tracker.


More information about the webkit-reviews mailing list