[webkit-reviews] review granted: [Bug 68237] [V8] REGRESSION(94783): calling the binding script during V8 context creation slows down page loads : [Attachment 107631] Call the binding script lazily

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted  review:
Bug 68237: [V8] REGRESSION(94783): calling the binding script during V8 context
creation slows down page loads
https://bugs.webkit.org/show_bug.cgi?id=68237

Attachment 107631: Call the binding script lazily
https://bugs.webkit.org/attachment.cgi?id=107631&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107631&action=review


This looks good overall, thanks. I have one comment about the robustness of the
code, but because this is such a high priority issue in Chromium I'm going to
mark this r+ / cq+ and we can deal with the robustness issue later.

> Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:42
> +    v8::Handle<v8::Object> arrayBufferView =
prototype->GetPrototype().As<v8::Object>();

Is there a more robust way to either find the ArrayBufferView prototype or
check that we've found it with this walk? In a future version of the typed
array spec a subtype of Uint8Array may be added (see
http://www.khronos.org/registry/typedarray/specs/latest/#7.1 ) and this code
would break if so.