[webkit-reviews] review granted: [Bug 68256] CodeGeneratorGObject should use C++ style comments for ENABLE guards : [Attachment 107680] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 68256: CodeGeneratorGObject should use C++ style comments for ENABLE guards
https://bugs.webkit.org/show_bug.cgi?id=68256

Attachment 107680: Patch
https://bugs.webkit.org/attachment.cgi?id=107680&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107680&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:58
> + * This file is part of the WebKit open source project.
> + * This file has been generated by generate-bindings.pl. DO NOT MODIFY!

Not specific to this patch, really, but I don’t think that adding stars to
every line improves this comment. In fact, I think this format should be
considered an anti-pattern in the future. Those additional stars make it
slightly easier to spot that it's a comment, but also make comments harder to
edit with any non-advanced editing tools.

If we really want something on every line, then we should just use // comments.
The whole benefit of /* */ comments is that they are multiline without
requiring additional characters on every line.