[webkit-reviews] review granted: [Bug 68162] [chromium]The focus of an input field inside an Iframe doesn't get cleared even though clearFocusedNode is called. : [Attachment 107608] updated patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted chandra shekar vallala
<chandra.vallala at motorola.com>'s request for review:
Bug 68162: [chromium]The focus of an input field inside an Iframe doesn't get
cleared even though clearFocusedNode is called.
https://bugs.webkit.org/show_bug.cgi?id=68162

Attachment 107608: updated patch
https://bugs.webkit.org/attachment.cgi?id=107608&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107608&action=review


> Source/WebKit/chromium/tests/WebFrameTest.cpp:239
> +class TestWebViewClient : public WebViewClient { };

I'm not 100% clear why we need this class.  Can't we just use WebViewClient
directly?

> Source/WebKit/chromium/ChangeLog:7
> +	   [chromium]The focus of an input field inside an Iframe doesn't get
cleared even though clearFocusedNode is called.
> +	   https://bugs.webkit.org/show_bug.cgi?id=68162
> +
> +	   Reviewed by NOBODY (OOPS!).
> +

In the future, it would be better to add more explanation to the ChangeLog
entry about why you're making this change.  It's not just a huge deal for this
patch, but it's a good habit.