[webkit-reviews] review granted: [Bug 68234] Web Inspector: UI performance tests are required. : [Attachment 107645] [patch] third version

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 68234: Web Inspector: UI performance tests are required.
https://bugs.webkit.org/show_bug.cgi?id=68234

Attachment 107645: [patch] third version
https://bugs.webkit.org/attachment.cgi?id=107645&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107645&action=review


> LayoutTests/inspector/performance/resources/performance-test.js:10
> +	   this._testStartTime = new Date().valueOf();

no need for valueOf

> LayoutTests/inspector/performance/resources/performance-test.js:29
> +	       var time = new Date().valueOf();

ditto

> LayoutTests/inspector/performance/resources/performance-test.js:44
> +		   setTimeout(this._runTest.bind(this), 0);

You should queue execution instead.

> LayoutTests/inspector/performance/resources/performance-test.js:59
> +		   samples.sort( function(a, b) { return a - b; });

erroneous " " between ( and function