[webkit-reviews] review denied: [Bug 68234] Web Inspector: UI performance tests are required. : [Attachment 107641] [patch] initial version

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 16 06:55:47 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 68234: Web Inspector: UI performance tests are required.
https://bugs.webkit.org/show_bug.cgi?id=68234

Attachment 107641: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=107641&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107641&action=review


> LayoutTests/inspector/performance/resources/show-panel-network.html:29
> +	       timer.finish(timerCookie);

Either you should use cookie to refer to timer or you should make finish mark
test as completed.


More information about the webkit-reviews mailing list