[webkit-reviews] review requested: [Bug 68239] Depend on harfbuzz for OS=Android as well : [Attachment 107637] Patch

[bugzilla-daemon at webkit.org]

Peter Beverloo <peter at chromium.org> has asked  for review:
Bug 68239: Depend on harfbuzz for OS=Android as well
https://bugs.webkit.org/show_bug.cgi?id=68239

Attachment 107637: Patch
https://bugs.webkit.org/attachment.cgi?id=107637&action=review

------- Additional Comments from Peter Beverloo <peter at chromium.org>
(In reply to comment #2)
> (From update of attachment 107634 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=107634&action=review
> 
> > Source/WebCore/ChangeLog:6
> > +	     Android depends on harfbuzz as well, so reflect that in the
project
> 
> 'as well as GTK'

That would say that Android depends on GTK too, which is not the case.	I've
rephrased the sentence.

> 
> > Source/WebCore/ChangeLog:8
> > +	     explicitly including ctype.h, as isspace otherwise won't be
enabled.
> 
> s/enabled/declared ?

Done.

Thanks!