[webkit-reviews] review granted: [Bug 68239] Depend on harfbuzz for OS=Android as well : [Attachment 107634] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 16 04:46:16 PDT 2011


Steve Block <steveblock at google.com> has granted Peter Beverloo
<peter at chromium.org>'s request for review:
Bug 68239: Depend on harfbuzz for OS=Android as well
https://bugs.webkit.org/show_bug.cgi?id=68239

Attachment 107634: Patch
https://bugs.webkit.org/attachment.cgi?id=107634&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107634&action=review


> Source/WebCore/ChangeLog:6
> +	   Android depends on harfbuzz as well, so reflect that in the project

'as well as GTK'

> Source/WebCore/ChangeLog:8
> +	   explicitly including ctype.h, as isspace otherwise won't be enabled.


s/enabled/declared ?


More information about the webkit-reviews mailing list