[webkit-reviews] review granted: [Bug 67840] Web Inspector: [Extensions API] support extensions for remote inspector front-end : [Attachment 107628] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 67840: Web Inspector: [Extensions API] support extensions for remote
inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=67840

Attachment 107628: patch
https://bugs.webkit.org/attachment.cgi?id=107628&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107628&action=review


> Source/WebCore/WebCore.gypi:6464
> +	       'inspector/front-end/ExtensionAPI.js',

Can we glue these together? They seem to be related.

> Source/WebKit/chromium/scripts/generate_devtools_extension_api.py:34
> +def write_devtools_extension_api(output, input_names):

I don't think you should diverge static API generation from dynamic API
generation.

> Source/WebKit/chromium/scripts/generate_devtools_extension_api.py:60
> +	   print('usage: %s output_js inpit_files_list ...' % argv[0])

input