[webkit-reviews] review requested: [Bug 68231] [EFL] Revert pointer operator coding style in ewk_view : [Attachment 107622] Patch for ewk_view.cpp
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 16 01:24:51 PDT 2011
Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked for review:
Bug 68231: [EFL] Revert pointer operator coding style in ewk_view
https://bugs.webkit.org/show_bug.cgi?id=68231
Attachment 107622: Patch for ewk_view.cpp
https://bugs.webkit.org/attachment.cgi?id=107622&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
I adjust webkit rule into ewk_view.cpp first.
However, I'm not sure whether we should adjust this rule into ewk_view.h as
well. Because, ewk_view.h is public header, which is included by C application.
In addition, pointer operator placement of public header differs from .cpp
fliles in GTK port.
For example, in webkit_web_view_set_settings function case,
- webkitwebview.h
WEBKIT_API void webkit_web_view_set_settings(WebKitWebView *webView,
WebKitWebSettings *settings);
- webkitwebview.cpp
void webkit_web_view_set_settings(WebKitWebView* webView, WebKitWebSettings*
webSettings)
More information about the webkit-reviews
mailing list