[webkit-reviews] review granted: [Bug 68213] remove redundant and error-prone semantics with m_dirtyRect and m_contentsDirty in LayerChromium. : [Attachment 107595] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 15 23:55:46 PDT 2011


James Robinson <jamesr at chromium.org> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 68213: remove redundant and error-prone semantics with m_dirtyRect and
m_contentsDirty in LayerChromium.
https://bugs.webkit.org/show_bug.cgi?id=68213

Attachment 107595: Patch
https://bugs.webkit.org/attachment.cgi?id=107595&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107595&action=review


> Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp:72
> +    if (!m_dirtyRect.isEmpty()) {

Since you're here, this if check is clearly unnecessary.  Can you remove it?


More information about the webkit-reviews mailing list