[webkit-reviews] review granted: [Bug 68205] Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE) : [Attachment 107602] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 68205: Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=68205

Attachment 107602: Patch
https://bugs.webkit.org/attachment.cgi?id=107602&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107602&action=review


build-webkit changes?  You might want to grep for"database_" as well.

> configure.ac:1135
> +AM_CONDITIONAL([ENABLE_SQL_DATABASE],[test "$enable_sql_database" = "yes"])

I'm surprised this isn't referenced in more places in this file.

> Source/JavaScriptCore/wtf/Platform.h:816
> -#if !defined(ENABLE_DATABASE)
> -#define ENABLE_DATABASE 1
> +#if !defined(ENABLE_SQL_DATABASE)
> +#define ENABLE_SQL_DATABASE 1
>  #endif

I thought we'd moved away from this model?