[webkit-reviews] review denied: [Bug 66198] [CSSRegions] Regions should not slice line box rendering : [Attachment 106330] Patch V5 fixed style

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied  review:
Bug 66198: [CSSRegions] Regions should not slice line box rendering
https://bugs.webkit.org/show_bug.cgi?id=66198

Attachment 106330: Patch V5 fixed style
https://bugs.webkit.org/attachment.cgi?id=106330&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=106330&action=review


This patch fails a bunch of printing tests.  See LayoutTests/printing.

> Source/WebCore/rendering/RenderBlock.cpp:6102
>      return logicalOffset + (remainingLogicalHeight ? remainingLogicalHeight
: pageLogicalHeight);

if (!renderView->hasRenderFlowThread()) {
 6185	     LayoutUnit pageLogicalHeight =
renderView->layoutState()->m_pageLogicalHeight;
 6186	     LayoutUnit remainingHeight = pageLogicalHeight - layoutMod(offset,
pageLogicalHeight);
 6187	     if (includeBoundaryPoint) {
 6188		 // If includeBoundaryPoint is true the line exactly on the top
edge of a
 6189		 // column will act as being part of the previous column.
 6190		 remainingHeight = layoutMod(remainingHeight,
pageLogicalHeight);
 6191	     }
 6192	     return remainingHeight;
 6193	 }

> Source/WebCore/rendering/RenderBlock.cpp:6197
> +

LayoutUnit pageLogicalHeight = layoutState->m_pageLogicalHeight;
6119	 LayoutSize delta = layoutState->m_layoutOffset -
layoutState->m_pageOffset;
6120	 LayoutUnit offset = isHorizontalWritingMode() ? delta.height() :
delta.width();
6121	 LayoutUnit remainingLogicalHeight = layoutMod(pageLogicalHeight -
layoutMod(offset + logicalOffset, pageLogicalHeight), pageLogicalHeight);