[webkit-reviews] review granted: [Bug 68057] Eliminate Length::undefinedLength = -1 and replace with Undefined LengthType. : [Attachment 107561] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 68057: Eliminate Length::undefinedLength = -1 and replace with Undefined
LengthType.
https://bugs.webkit.org/show_bug.cgi?id=68057

Attachment 107561: Patch
https://bugs.webkit.org/attachment.cgi?id=107561&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107561&action=review


> Source/WebCore/platform/Length.h:124
> +    // Note: May only be called for Fixed, Percent and Auto lengths.
> +    //	Other types will ASSERT in order to catch invalid length
calculations.

We normally don’t line up subsequent lines with spaces like this.

> Source/WebCore/platform/Length.h:139
> +	   return 0;

It would also be good to have an ASSERT_NOT_REACHED outside the switch
statement.

> Source/WebCore/platform/Length.h:160
> +	   return 0;

It would also be good to have an ASSERT_NOT_REACHED outside the switch
statement.

> Source/WebCore/platform/Length.h:178
> +	   return 0;

It would also be good to have an ASSERT_NOT_REACHED outside the switch
statement.