[webkit-reviews] review denied: [Bug 68192] Add method to scroll current node to specific position in Chromium WebKit API : [Attachment 107552] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Varun Jain
<varunjain at chromium.org>'s request for review:
Bug 68192: Add method to scroll current node to specific position in Chromium
WebKit API
https://bugs.webkit.org/show_bug.cgi?id=68192

Attachment 107552: Patch
https://bugs.webkit.org/attachment.cgi?id=107552&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107552&action=review


This logic seems to be in the wrong place. If you had it on Element, you could
at least test it with window.internals.

> ChangeLog:6
> +	   Reviewed by NOBODY (OOPS!).

No test?

> Source/WebKit/chromium/src/WebViewImpl.cpp:1834
> +	   frame->view()->scrollBy(scrollOffset);

Missing indent.