[webkit-reviews] review denied: [Bug 45761] Don't clamp cubic-bezier timing functions between 0 and 1 : [Attachment 107476] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 15 13:19:48 PDT 2011

Dean Jackson <dino at apple.com> has denied Peter Beverloo <peter at chromium.org>'s
request for review:
Bug 45761: Don't clamp cubic-bezier timing functions between 0 and 1

Attachment 107476: Patch

------- Additional Comments from Dean Jackson <dino at apple.com>
Could you add a test that makes sure values are clamped? ie. animate colors.
Unfortunately our hacky test-helping library doesn't really support colors that
well. I added something like it in the test for transitions on SVG properties.

Also, it's not clear what effect this will have on hardware animations using
Core Animation. I'll have to check.

r- just because I think we have to exercise the clamping now that it is
possible to produce values outside the normal bounds.

More information about the webkit-reviews mailing list