[webkit-reviews] review granted: [Bug 68122] Unzip initialization lists and constructors in JSCell hierarchy (7/7) : [Attachment 107424] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 68122: Unzip initialization lists and constructors in JSCell hierarchy
(7/7)
https://bugs.webkit.org/show_bug.cgi?id=68122

Attachment 107424: Patch
https://bugs.webkit.org/attachment.cgi?id=107424&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107424&action=review


r=me

> Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm:188
>	   // FIXME: deprecatedGetDOMStructure uses the prototype off of the
wrong global object
>	   // exec-globalData() is also likely wrong.
>	   Structure* domStructure =
deprecatedGetDOMStructure<ProxyRuntimeMethod>(exec);

Can you remove this FIXME?

> Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h:46
>	   // FIXME: deprecatedGetDOMStructure uses the prototype off of the
wrong global object.
>	   // exec->globalData() is also likely wrong.
>	   JSC::Structure* structure =
WebCore::deprecatedGetDOMStructure<ProxyRuntimeObject>(exec);

Ditto.