[webkit-reviews] review granted: [Bug 63540] XMLDocumentParserQt.cpp incorrectly converts 0-based number into 1-based number : [Attachment 107501] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Peter Rybin
<peter.rybin at gmail.com>'s request for review:
Bug 63540: XMLDocumentParserQt.cpp incorrectly converts 0-based number into
1-based number
https://bugs.webkit.org/show_bug.cgi?id=63540

Attachment 107501: Patch
https://bugs.webkit.org/attachment.cgi?id=107501&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107501&action=review


Thanks.

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:451
> -    return m_tokenizer->lineNumber();
> +    return ZeroBasedNumber::fromZeroBasedInt(m_tokenizer->lineNumber());

Should m_tokenizer->lineNumber() return a ZeroBasedNumber ?