[webkit-reviews] review denied: [Bug 68148] Implement an ErrorEvent constructor for JSC : [Attachment 107475] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 15 10:15:51 PDT 2011


Sam Weinig <sam at webkit.org> has denied Kentaro Hara <haraken at chromium.org>'s
request for review:
Bug 68148: Implement an ErrorEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68148

Attachment 107475: Patch
https://bugs.webkit.org/attachment.cgi?id=107475&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107475&action=review


> Source/WebCore/dom/ErrorEvent.h:78
> +    unsigned long m_lineNumber;

This should stay an unsigned int.  unsigned long in WebIDL maps to unsigned int
in C.  Same with the the init.


More information about the webkit-reviews mailing list