[webkit-reviews] review granted: [Bug 68041] REGRESSION (Safari 5.1-r95043): Incorrect box-shadow offset : [Attachment 107502] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 68041: REGRESSION (Safari 5.1-r95043): Incorrect box-shadow offset
https://bugs.webkit.org/show_bug.cgi?id=68041

Attachment 107502: Patch
https://bugs.webkit.org/attachment.cgi?id=107502&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107502&action=review


> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1030
> +	   // Work around <rdar://problem/5539388> by ensuring that the offsets
will get truncated
> +	   // to the desired integer.

You may want to add a link to <rdar://problem/10056277> as well.

> LayoutTests/fast/box-shadow/one-pixel-offset-bottom-right.html:1
> +<div style="width: 100px; height: 100px; -webkit-box-shadow: black 1px 1px;
background: red;">

Please don't use red in a passing test.

Don't we have existing tests that show this shadow offset problem? I'm not sure
we need a new one.