[webkit-reviews] review requested: [Bug 68161] Web Inspector: Provide completions for object literals, arrays and functions : [Attachment 107497] Patch

[bugzilla-daemon at webkit.org]

tonistiigi at gmail.com has asked	for review:
Bug 68161: Web Inspector: Provide completions for object literals, arrays and
functions
https://bugs.webkit.org/show_bug.cgi?id=68161

Attachment 107497: Patch
https://bugs.webkit.org/attachment.cgi?id=107497&action=review

------- Additional Comments from tonistiigi at gmail.com
Bit mixed feelings about adding this to the utils.rangeOfWord because it only
makes sense on moving backwards. On the other hand, implementing the moving
between textnodes again in a separate function wouldn't be good either.

There is also an edge case where expression could change the input value
depending on the execution count. Then there would be possibility that
expression is already run first when getting the completions. Other way would
be to parse it so that all objects/function bodies remain empty {} and arrays
empty []. Then we could at least get the completions for prototype properties.
In my opinion while debugging it adds very much more if we get all completions
for the actual object. I believe same kind of multi-execution also occures on
watched expressions.

This should also fix a bug where previously "foo". provided completions but for
example "foo{". didn't.