[webkit-reviews] review granted: [Bug 67190] A Media Element ie: <Audio> or <video>, without tabindex cannot be selected with keyboard (TAB Key). : [Attachment 107160] Updated patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Deepak Sherveghar
<bpwv64 at motorola.com>'s request for review:
Bug 67190: A Media Element ie: <Audio> or <video>,  without tabindex cannot be
selected with keyboard (TAB Key).
https://bugs.webkit.org/show_bug.cgi?id=67190

Attachment 107160: Updated patch
https://bugs.webkit.org/attachment.cgi?id=107160&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107160&action=review


r=me. Please address Ryosuke's concerns before committing.

When you have a new patch, pre-fill "Reviewed by Antonio Gomes" field, and set
cq? only. Then any committer can cq+ it.

> LayoutTests/fast/events/tabindex-focus-blur-all-expected.txt:1
> -331 focus / 331 blur events dispatched, and should be 331 / 331 PASSED
> +333 focus / 333 blur events dispatched, and should be 333 / 333 PASSED

this part looks suspicious.

> LayoutTests/fast/events/resources/tabindex-focus-blur-all.js:57
> -    var resultSummary = focusCount+" focus / "+blurCount+" blur events
dispatched, and should be 331 / 331 ";
> +    var resultSummary = focusCount+" focus / "+blurCount+" blur events
dispatched, and should be 333 / 333 ";

ditto.