[webkit-reviews] review granted: [Bug 50151] Crash in RenderBox::paintMaskImages : [Attachment 107362] Proposed fix: patch paintMaskImages to properly check the image(), also avoid calling hasImage() in a loop as it is already looping.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 50151: Crash in RenderBox::paintMaskImages
https://bugs.webkit.org/show_bug.cgi?id=50151

Attachment 107362: Proposed fix: patch paintMaskImages to properly check the
image(), also avoid calling hasImage() in a loop as it is already looping.
https://bugs.webkit.org/attachment.cgi?id=107362&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107362&action=review


> LayoutTests/fast/css/empty-webkit-mask-crash.html:4
> +    // We need to dump the image, we don't care about the layout
information.

It would be nice if the text content said "This test should not crash".

> Source/WebCore/ChangeLog:3
> +	   chrome.dll!WebCore::RenderBox::paintMaskImages ReadAV at NULL (various
hashes)

Retitle the bug to reflect the actual issue, please.

> Source/WebCore/ChangeLog:10
> +	   The crash stems from the fact that FillLayer::hasImage would over
the linked list

missing verb (would __ over)