[webkit-reviews] review denied: [Bug 67625] Clean up CSSPropertyTextDecoration implementation and ETextDecoration usage. : [Attachment 106390] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 67625: Clean up CSSPropertyTextDecoration implementation and
ETextDecoration usage.
https://bugs.webkit.org/show_bug.cgi?id=67625

Attachment 106390: Patch
https://bugs.webkit.org/attachment.cgi?id=106390&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106390&action=review


> Source/WebCore/rendering/style/RenderStyle.h:195
> -	   unsigned _text_decorations : 4;
> +	   ETextDecoration _text_decorations : ETextDecorationBits;

This is going to hit a bug in Visual C++.

> Source/WebCore/rendering/style/RenderStyleConstants.h:339
> +static const size_t ETextDecorationBits = 4;

I like this.