[webkit-reviews] review granted: [Bug 67989] Move RenderObject::markContainingBlocksForLayout() to RenderObject.cpp : [Attachment 107308] Patch 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 14 21:41:22 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 67989: Move RenderObject::markContainingBlocksForLayout() to
RenderObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=67989

Attachment 107308: Patch 3
https://bugs.webkit.org/attachment.cgi?id=107308&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107308&action=review


> Source/WebCore/rendering/RenderObject.cpp:596
> +	   || (object->hasOverflowClip() &&
!object->style()->width().isIntrinsicOrAuto() &&
!object->style()->height().isIntrinsicOrAuto() &&
!object->style()->height().isPercent() && !object->isTableCell());

Can we split this into two lines? This line seems too long.


More information about the webkit-reviews mailing list