[webkit-reviews] review denied: [Bug 68134] Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms : [Attachment 107427] Add ScrollbarThemeMock

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 14 18:29:11 PDT 2011


James Robinson <jamesr at chromium.org> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 68134: Make custom scrollbar theme for use in DRT, to reduce pixel diffs
between platforms
https://bugs.webkit.org/show_bug.cgi?id=68134

Attachment 107427: Add ScrollbarThemeMock
https://bugs.webkit.org/attachment.cgi?id=107427&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107427&action=review


> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:116
> +    if (1) {
> +	   DEFINE_STATIC_LOCAL(ScrollbarThemeMock, theme, ());
> +	   return &theme;
> +    }

This seems like a debugging thing - did you intend to check it in?  Won't this
cause the actual mac scrollbar theming code to not be used?

> Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:31
> +using namespace std;

this doesn't appear to be used


More information about the webkit-reviews mailing list