[webkit-reviews] review denied: [Bug 66994] Implement Error.stack : [Attachment 107215] fixed patch for win-bot

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 14 15:10:58 PDT 2011


Oliver Hunt <oliver at apple.com> has denied Juan C. Montemayor <j.mont at me.com>'s
request for review:
Bug 66994: Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994

Attachment 107215: fixed patch for win-bot
https://bugs.webkit.org/attachment.cgi?id=107215&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107215&action=review


r- due to the problem with printStack, but that's it.

> LayoutTests/fast/js/stack-trace-expected.txt:9
> +    0   normalInner at
file:///Users/jmont/webkit/OpenSource/LayoutTests/fast/js/script-tests/stack-tr
ace.js:21
> +    1   normalOuter at
file:///Users/jmont/webkit/OpenSource/LayoutTests/fast/js/script-tests/stack-tr
ace.js:20
> +    2   at
file:///Users/jmont/webkit/OpenSource/LayoutTests/fast/js/script-tests/stack-tr
ace.js:26

These will lead to sadness

> LayoutTests/fast/js/script-tests/stack-trace.js:9
> +		debug("    " + i + "   " + stackTrace[level]);

I think you want to do stackTrace[level].replace(location, "") here to make
these tests happier


More information about the webkit-reviews mailing list