[webkit-reviews] review granted: [Bug 68116] Tiered compilation heuristics do not account for value profile fullness : [Attachment 107399] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 68116: Tiered compilation heuristics do not account for value profile
fullness
https://bugs.webkit.org/show_bug.cgi?id=68116

Attachment 107399: the patch
https://bugs.webkit.org/attachment.cgi?id=107399&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107399&action=review


Correct the printf bit before landing.

Would be nice to avoid unnecessary renames (buckets->m_buckets, etc) in future,
as they add noise to the patch.

> Source/JavaScriptCore/jit/JITStubs.cpp:1840
> +	   if (error)
> +	       fprintf(stderr, "WARNING: optimized compilation from loop
failed.\n");

Should be in a VERBOSE_OSR block?

Future patch might want to define a OSR_LOG() macro which might be nicer in the
long run