[webkit-reviews] review granted: [Bug 67750] Create a delegate class to help cleanly isolate the chromium compositor API : [Attachment 107377] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Antoine Labour
<piman at chromium.org>'s request for review:
Bug 67750: Create a delegate class to help cleanly isolate the chromium
compositor API
https://bugs.webkit.org/show_bug.cgi?id=67750

Attachment 107377: Patch
https://bugs.webkit.org/attachment.cgi?id=107377&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107377&action=review


Looks good.  Left one comment FYI but this is fine to land as-is

> Source/WebCore/platform/graphics/chromium/LayerChromium.h:60
> +    virtual ~CCLayerDelegate() { }

another thing: we normally put the d'tor in the protected section, since it
rarely makes sense to delete a delegate through a CCLayerDelegate*