[webkit-reviews] review denied: [Bug 48544] support -webkit-tap-highlight-color : [Attachment 106856] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 14 12:12:15 PDT 2011


Sam Weinig <sam at webkit.org> has denied Johnny(Jianning) Ding
<jnd at chromium.org>'s request for review:
Bug 48544: support -webkit-tap-highlight-color
https://bugs.webkit.org/show_bug.cgi?id=48544

Attachment 106856: patch v1
https://bugs.webkit.org/attachment.cgi?id=106856&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106856&action=review


> Source/WebCore/platform/graphics/Color.h:166
> +    static const RGBA32 tapHighlight = 0x33000000;

This doesn't seem like a great place for this to go.  It seems like it should
just be in RenderTheme.


More information about the webkit-reviews mailing list