[webkit-reviews] review denied: [Bug 68079] Set but unused variables cleanup in v8 bindings (gcc 4.6) : [Attachment 107336] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 14 11:59:43 PDT 2011

Adam Barth <abarth at webkit.org> has denied ph34r <pph34r at gmail.com>'s request
for review:
Bug 68079: Set but unused variables cleanup in v8 bindings (gcc 4.6)

Attachment 107336: Patch

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107336&action=review

> Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:105
>	   imp->setLength(value->Uint32Value(), ec);

Are you sure we're not supposed to use newLength there?

> Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp:137
> -	   v8::Handle<v8::String> stringMessage = message->ToString();
> +	   message->ToString();

What's the point of calling ToString on this object and ignoring the result?

More information about the webkit-reviews mailing list