[webkit-reviews] review granted: [Bug 68050] Layout Test fast/css/transformed-mask.html, fast/reflections/reflection-masks.html are failing : [Attachment 107341] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 14 09:30:50 PDT 2011
Adam Roben (:aroben) <aroben at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 68050: Layout Test fast/css/transformed-mask.html,
fast/reflections/reflection-masks.html are failing
https://bugs.webkit.org/show_bug.cgi?id=68050
Attachment 107341: Patch
https://bugs.webkit.org/attachment.cgi?id=107341&action=review
------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107341&action=review
> Source/WebCore/css/CSSStyleSelector.cpp:3317
> NinePieceImage mask;
> - mask.setImageSlices(LengthBox(0)); // For backwards compatibility,
just make the mask box image slices 0 instead of 100%.
> - mask.setBorderSlices(LengthBox()); // The slices default to auto.
> + mask.setMaskDefaults();
Maybe it would be better to have a separate NinePieceImage constructor that did
this for you?
More information about the webkit-reviews
mailing list