[webkit-reviews] review denied: [Bug 67592] Take pageScaleFactor into account for MouseRelatedEvents. : [Attachment 107327] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 14 09:12:35 PDT 2011
Simon Fraser (smfr) <simon.fraser at apple.com> has denied John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 67592: Take pageScaleFactor into account for MouseRelatedEvents.
https://bugs.webkit.org/show_bug.cgi?id=67592
Attachment 107327: Patch
https://bugs.webkit.org/attachment.cgi?id=107327&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=107327&action=review
> LayoutTests/fast/events/script-tests/page-scaled-mouse-click-iframe.js:2
> +description("This tests that page scaling does not affect mouse event pageX
and pageY coordinates for " +
> + "content embedded in an iframe.");
It looks like it's also testing CSS transforms?
> LayoutTests/fast/events/script-tests/page-scaled-mouse-click-iframe.js:4
> +var html = document.getElementsByTagName("html")[0];
This can be document.documentElement.
> LayoutTests/fast/events/script-tests/page-scaled-mouse-click.js:3
> +var html = document.getElementsByTagName("html")[0];
Ditto
More information about the webkit-reviews
mailing list