[webkit-reviews] review granted: [Bug 68080] query SystemParametersInfo for GDI font smoothing settings : [Attachment 107332] Patch

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has granted Mike Reed
<reed at google.com>'s request for review:
Bug 68080: query SystemParametersInfo for GDI font smoothing settings
https://bugs.webkit.org/show_bug.cgi?id=68080

Attachment 107332: Patch
https://bugs.webkit.org/attachment.cgi?id=107332&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107332&action=review


Looks good.  r=me

> Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:108
> +    static bool gInited;
> +    static uint32_t gFlags;

Nit:  since gFlags is a function-level static anyway, if you wanted, you could
save the gInited bool by refactoring the initialization into another function
and doing:

static uint32_t gFlags = getTextFlagsFromGDI();
return gFlags;

Of course, a new function to save a bool, maybe not worth it.  :)