[webkit-reviews] review requested: [Bug 67986] Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel : [Attachment 107324] [patch] next iteration.

[bugzilla-daemon at webkit.org]

Ilya Tikhonovsky <loislo at chromium.org> has asked  for review:
Bug 67986: Web Inspector: requestAnimationFrame callbacks don't show up in the
timeline panel
https://bugs.webkit.org/show_bug.cgi?id=67986

Attachment 107324: [patch] next iteration.
https://bugs.webkit.org/attachment.cgi?id=107324&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
(In reply to comment #12)
> (From update of attachment 107319 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=107319&action=review
> 
> Almost there.
> 
> > LayoutTests/inspector/timeline/timeline-animation-frame-expected.txt:6
> > +	 stackTrace : <object>

fixed


> You need to generate custom expectations (these are chromium's)
> 
> > LayoutTests/inspector/timeline/timeline-animation-frame.html:26
> > +	     InspectorTest.evaluateInPage("performActions()", step2);
> 
> You could set a console sniffer and do console.log from animation frame
callback instead.

done

> > LayoutTests/inspector/timeline/timeline-animation-frame.html:39
> > +	     setTimeout(step2, 10);
> 
> Then you would not need this timeout that is going to be flaky.

done
> 
> > Source/WebCore/bindings/v8/V8Proxy.cpp:518
> > +
> 
> Too
> 
> > Source/WebCore/bindings/v8/V8Proxy.cpp:520
> > +
> 
> many
> 
> > Source/WebCore/bindings/v8/V8Proxy.cpp:522
> > +
> 
> blank lines...

done
> 
> > Source/WebCore/bindings/v8/V8Proxy.h:-192
> > -
> 
> No need to change this
> 

done

> > Source/WebCore/dom/ScriptedAnimationController.cpp:136
> >  
> 
> No need to add line
> 
> > Source/WebCore/inspector/InspectorInstrumentation.h:503
> >	 FAST_RETURN_IF_NO_FRONTENDS(InspectorInstrumentationCookie());
> 
> if (!page)
>     return;
> 
> Otherwise ASSERT(page) will trigger in instrumentingAgentsForPage.

We have this check exists in instrumentingAgentsForPage