[webkit-reviews] review denied: [Bug 67840] Web Inspector: [Extensions API] support extensions for remote inspector front-end : [Attachment 106860] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 67840: Web Inspector: [Extensions API] support extensions for remote
inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=67840

Attachment 106860: patch
https://bugs.webkit.org/attachment.cgi?id=106860&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106860&action=review


> Source/WebCore/inspector/front-end/ExtensionServer.js:224
> +	       iframe.addEventListener("load",
this._postExtensionAPI.bind(this), false);

This effectively declares that remote and non-remote extensions should be
implemented differently. As is, it will result in more confusion than benefit.

> Source/WebCore/inspector/front-end/ExtensionServer.js:536
> +    _addExtension: function(startPage, onload)

I'd expose this method so that it could be called from the bookmarklet.