[webkit-reviews] review denied: [Bug 67986] Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel : [Attachment 107319] [patch] next iteration.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 67986: Web Inspector: requestAnimationFrame callbacks don't show up in the
timeline panel
https://bugs.webkit.org/show_bug.cgi?id=67986

Attachment 107319: [patch] next iteration.
https://bugs.webkit.org/attachment.cgi?id=107319&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107319&action=review


Almost there.

> LayoutTests/inspector/timeline/timeline-animation-frame-expected.txt:6
> +    stackTrace : <object>

You need to generate custom expectations (these are chromium's)

> LayoutTests/inspector/timeline/timeline-animation-frame.html:26
> +	   InspectorTest.evaluateInPage("performActions()", step2);

You could set a console sniffer and do console.log from animation frame
callback instead.

> LayoutTests/inspector/timeline/timeline-animation-frame.html:39
> +	   setTimeout(step2, 10);

Then you would not need this timeout that is going to be flaky.

> Source/WebCore/bindings/v8/V8Proxy.cpp:518
> +

Too

> Source/WebCore/bindings/v8/V8Proxy.cpp:520
> +

many

> Source/WebCore/bindings/v8/V8Proxy.cpp:522
> +

blank lines...

> Source/WebCore/bindings/v8/V8Proxy.h:-192
> -

No need to change this

> Source/WebCore/dom/ScriptedAnimationController.cpp:136
>  

No need to add line

> Source/WebCore/inspector/InspectorInstrumentation.h:503
>      FAST_RETURN_IF_NO_FRONTENDS(InspectorInstrumentationCookie());

if (!page)
    return;

Otherwise ASSERT(page) will trigger in instrumentingAgentsForPage.