[webkit-reviews] review denied: [Bug 67986] Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel : [Attachment 107187] [patch] third version. with fixed style error

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 67986: Web Inspector: requestAnimationFrame callbacks don't show up in the
timeline panel
https://bugs.webkit.org/show_bug.cgi?id=67986

Attachment 107187: [patch] third version. with fixed style error
https://bugs.webkit.org/attachment.cgi?id=107187&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=107187&action=review


> LayoutTests/inspector/timeline/timeline-test.js:55
> +	   if (async && waitForTypeName) {

I'd move this into the new test unless there are more clients.

> Source/WebCore/bindings/v8/V8Proxy.cpp:844
> +void V8Proxy::functionOrigin(v8::Handle<v8::Function> function, String*
resourceName, int* lineNumber)

v8::Local<v8::Value> V8Proxy::instrumentFunctionCall(Page*, function, args,
argv)
{
    InspectorInstrumentation::willCallFunction(page);
    function->Call();
    InspectorInstrumentation::didCallFunction(cookie);
}

> Source/WebCore/dom/ScriptedAnimationController.cpp:129
> +		  
InspectorInstrumentation::didFireAnimationFrameEvent(m_document);

You should use cookie here as well.