[webkit-reviews] review requested: [Bug 67864] [Qt] Win32 builds with threads turned off : [Attachment 107301] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 14 00:23:16 PDT 2011


Csaba Osztrogonac <ossy at webkit.org> has asked  for review:
Bug 67864: [Qt] Win32 builds with threads turned off
https://bugs.webkit.org/show_bug.cgi?id=67864

Attachment 107301: proposed fix
https://bugs.webkit.org/attachment.cgi?id=107301&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
In my opinion QtWebKit on Windows should depends on pthread library.
Unfortunately it isn't packed with QtSDK, so user have to install
it manually from here: http://sourceware.org/pthreads-win32/

I tested it, and it works fine with MinGW, MSVC and on our bot (cross-MinGW on
Linux)

If this patch lands I'll update http://trac.webkit.org/wiki/BuildingQtOnWindows
to help developers how can they install pthread.


More information about the webkit-reviews mailing list